szetszwo commented on code in PR #10050:
URL: https://github.com/apache/ozone/pull/10050#discussion_r3037385550
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogStateManager.java:
##########
@@ -31,7 +32,7 @@
* DeletedBlockLogStateManager interface to
* manage deleted blocks and record them in the underlying persist store.
*/
-public interface DeletedBlockLogStateManager {
+public interface DeletedBlockLogStateManager extends SCMHandler {
Review Comment:
- Similarly, we should implement getType() here instead of the subclasses.
- We should do it for all the handler interfaces.
```java
@Override
default RequestType getType() {
return RequestType.BLOCK;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]