Gargi-jais11 commented on code in PR #10051:
URL: https://github.com/apache/ozone/pull/10051#discussion_r3042968935


##########
hadoop-ozone/dist/src/main/smoketest/cli/classpath.robot:
##########
@@ -48,3 +57,35 @@ Adds optional dir entries
                         Should Contain   ${output}   
${jars_dir}/ozone-insight/optional.jar
 
     [teardown]    Remove Directory    ${OZONE_COPY}    recursive=True
+
+Validate classpath succeeds when all jars are present
+    ${output} =         Execute          ozone --validate classpath 
ozone-insight
+                        Should Contain   ${output}   Validating classpath file:
+                        Should Contain   ${output}   Validation SUCCESSFUL
+
+Validate classpath fails when classpath descriptor is missing
+    ${output} =         Execute and checkrc    ozone --validate classpath 
hdds-nonexistent-artifact-7373    1
+                        Should Contain   ${output}   ERROR: Classpath file 
descriptor
+
+Validate classpath fails when a listed jar is missing
+    ${OZONE_COPY} =     Set Variable     ${TEMP_DIR}/ozone-validate-missing-jar
+    ${bogus_jar} =     Set Variable     
${TEMP_DIR}/ozone-robot-missing-7373.jar
+    Copy Directory      ${OZONE_DIR}     ${OZONE_COPY}

Review Comment:
   We can reduce the duplicacy here and move these 4 lines to a new keyword and 
call that keyword in both the test cases : `Validate classpath fails when a 
listed jar is missing` and `Validate continue allows daemon command after 
failed classpath check`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to