adoroszlai commented on code in PR #10056:
URL: https://github.com/apache/ozone/pull/10056#discussion_r3052619245
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -1012,7 +1018,7 @@ public void close() {
if (layoutVersionInDB != null &&
versionManager.getMetadataLayoutVersion() < layoutVersionInDB) {
LOG.info("New OM snapshot received with higher layout version {}. " +
- "Attempting to finalize current OM to that version.",
+ "Attempting to finalize current OM to that version.",
Review Comment:
nit: please avoid whitespace change
```suggestion
"Attempting to finalize current OM to that version.",
```
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -3659,7 +3665,7 @@ public TenantStateList listTenant() throws IOException {
// request.
try (TableIterator<String, ? extends KeyValue<String, OmDBTenantState>>
- iterator = tenantStateTable.iterator()) {
+ iterator = tenantStateTable.iterator()) {
Review Comment:
```suggestion
iterator = tenantStateTable.iterator()) {
```
##########
hadoop-ozone/cli-shell/src/main/java/org/apache/hadoop/ozone/shell/Shell.java:
##########
@@ -90,7 +91,7 @@ private int execute(CommandLine.ParseResult parseResult) {
return 0;
}
- TracingUtil.initTracing("shell", getOzoneConf());
+ TracingUtil.initTracing("shell",
getOzoneConf().getObject(TracingConfig.class));
Review Comment:
To reduce change, we can keep `initTracing(String, ConfigurationSource)`
(original signature) and delegate to `initTracing(String, TracingConfig)`.
(Sorry for not mentioning this earlier.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
