weimingdiit commented on PR #9892: URL: https://github.com/apache/ozone/pull/9892#issuecomment-4230630158
@smengcl @yandrey321 Not yet — this change was mainly motivated by the fact that putBlock is on the IO path and we currently do the feature-finalization check on every request. That said, I agree this should be backed by profiling data rather than assumption. I’m planning to use a dedicated microbenchmark or a small reproducible test program for evaluation. What do you think? I’ll collect a flame graph / profiler output for the putBlock workload and update the PR with: - whether VersionedDatanodeFeatures.isFinalized (or the underlying version-manager check / lock path) shows up on the hot path - before/after numbers - the exact workload/setup used If the profiling shows this is not a meaningful hotspot, I’m okay with dropping or reworking this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
