sreejasahithi commented on code in PR #10018:
URL: https://github.com/apache/ozone/pull/10018#discussion_r3071087184


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/SafeModeMetrics.java:
##########
@@ -59,6 +59,13 @@ public class SafeModeMetrics {
   @Metric private MutableGaugeLong numRequiredDatanodesThreshold;
   @Metric private MutableCounterLong currentRegisteredDatanodesCount;
 
+  @Metric("Wall-clock time (ms) SCM spent in safe mode for the last exit")
+  private MutableGaugeLong scmSafeModeExitDurationMs;
+  @Metric("Duration (ms) of the last Ratis container safe mode rule 
incremental refresh")
+  private MutableGaugeLong lastRatisContainerSafeModeRuleRefreshDurationMs;
+  @Metric("Duration (ms) of the last EC container safe mode rule incremental 
refresh")
+  private MutableGaugeLong lastEcContainerSafeModeRuleRefreshDurationMs;
+

Review Comment:
   Could you please add test for these metrics. Since the existing test 
infrastructure already sets up everything needed, coverage can be added with 
just a line or two in existing tests rather than writing new ones.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to