ChenSammi commented on code in PR #10022:
URL: https://github.com/apache/ozone/pull/10022#discussion_r3083958798
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerConfiguration.java:
##########
@@ -121,6 +121,15 @@ public final class DiskBalancerConfiguration {
"Unit could be defined with postfix (ns,ms,s,m,h,d).")
private long replicaDeletionDelay = Duration.ofMinutes(5).toMillis();
+ @Config(key = "hdds.datanode.disk.balancer.include.non.standard.containers",
Review Comment:
Agree with @errose28 and @sadanand48 .
Let's change the property to something like
"hdds.datanode.disk.balancer.container.states", which by default includes
CLOSED and QUASI_CLOSED now. If in future, if we need to include other
container state, only requires updating the default value of this property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
