[ 
https://issues.apache.org/jira/browse/HDDS-15040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ivan Andika updated HDDS-15040:
-------------------------------
    Description: 
Saw some inverted awaitTermination condition
{code:java}
if (executorService.awaitTermination(5, TimeUnit.SECONDS)) {
  executorService.shutdownNow();
} {code}
It should be 
{code:java}
if (!executorService.awaitTermination(5, TimeUnit.SECONDS)) {
  executorService.shutdownNow(); 
} {code}


  was:
We see some inverted awaitTermination condition
{code:java}
if (executorService.awaitTermination(5, TimeUnit.SECONDS)) {
  executorService.shutdownNow();
} {code}
It should be 
{code:java}
if (!executorService.awaitTermination(5, TimeUnit.SECONDS)) {
  executorService.shutdownNow(); 
} {code}



> Some ExecutorService#awaitTermination is inverted
> -------------------------------------------------
>
>                 Key: HDDS-15040
>                 URL: https://issues.apache.org/jira/browse/HDDS-15040
>             Project: Apache Ozone
>          Issue Type: Bug
>            Reporter: Ivan Andika
>            Assignee: Ivan Andika
>            Priority: Minor
>
> Saw some inverted awaitTermination condition
> {code:java}
> if (executorService.awaitTermination(5, TimeUnit.SECONDS)) {
>   executorService.shutdownNow();
> } {code}
> It should be 
> {code:java}
> if (!executorService.awaitTermination(5, TimeUnit.SECONDS)) {
>   executorService.shutdownNow(); 
> } {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to