devmadhuu commented on code in PR #9954:
URL: https://github.com/apache/ozone/pull/9954#discussion_r3092207885
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/StorageVolume.java:
##########
@@ -162,6 +165,9 @@ protected StorageVolume(Builder<?> b) throws IOException {
this.isDiskCheckEnabled = dnConf.isDiskCheckEnabled();
this.ioTestSlidingWindow = new
SlidingWindow(dnConf.getVolumeIOFailureTolerance(),
dnConf.getDiskCheckSlidingWindowTimeout(), b.getClock());
+ this.timeoutFailureSlidingWindow = new SlidingWindow(
+ dnConf.getVolumeIOFailureTolerance(), TIMEOUT_FAILURE_WINDOW,
+ b.getClock());
Review Comment:
@ptlrs , using `getVolumeIOFailureTolerance` is more meaningful because
there is no distinction we are making here whether the marking of volume
failure is due to real IO failure or it was simple timeout because of GC or due
to other kernel level disk issues. I initially made that separate and
@ChenSammi had the opinion to use same.
Also IMO, [SlidingWindow
class](https://github.com/apache/ozone/blob/9ff7eaa6c19bbd2e8aa951197127c503fe5b2159/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/SlidingWindow.java#L97)
should be left as is without introducing further magical numbers or
introducing the toggle checks to further complicate the things because we
always want to find out the volume failures, so why would we want to disable ?
Also the underlying semantics of SlidingWindow class in terms of general
programming will change if we introduce any custom controls on this class
working. That is my point of view, but @errose28 and @adoroszlai can comment
further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]