sodonnel commented on code in PR #10082:
URL: https://github.com/apache/ozone/pull/10082#discussion_r3099068880
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java:
##########
@@ -196,48 +240,19 @@ public int processAndSendCommands(
if (code != SCMException.ResultCodes.FAILED_TO_FIND_SUITABLE_NODE) {
throw e;
}
- // If we get here, we got an exception indicating the placement policy
- // was not able to find ANY nodes to satisfy the replication at one of
- // the processing stages (missing index, decom or maint). It is
- // possible that some commands were sent to partially fix the
- // replication, but a further run will be needed to fix the rest.
- // On a small cluster, it is possible that over replication could stop
- // nodes getting selected, so to check if that is the case, we run
- // the over rep handler, which may free some nodes for the next run.
if (replicaCount.isOverReplicated()) {
- LOG.debug("Container {} is both under and over replicated. Cannot " +
- "find enough target nodes, so handing off to the " +
- "OverReplication handler", container);
replicationManager.processOverReplicatedContainer(result);
}
-
- /* If we get here, the scenario is:
- 1. Under replicated.
- 2. Not over replicated.
Review Comment:
Why are all these comments getting removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]