ChenSammi commented on code in PR #10022:
URL: https://github.com/apache/ozone/pull/10022#discussion_r3115668244


##########
hadoop-hdds/docs/content/feature/DiskBalancer.md:
##########
@@ -238,16 +238,17 @@ ozone admin datanode diskbalancer report 
--in-service-datanodes --json
 
 The DiskBalancer's behavior can be controlled using the following 
configuration properties in `ozone-site.xml`.
 
-| Property                                                    | Default Value  
                                                                        | 
Description                                                                     
                                                                                
          |
-|-------------------------------------------------------------|----------------------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| `hdds.datanode.disk.balancer.enabled`                       | `false`        
                                                                        | If 
false, the DiskBalancer service on the Datanode is disabled. Configure it to 
true for diskBalancer to be enabled.                                            
        |
-| `hdds.datanode.disk.balancer.volume.density.threshold.percent` | `10.0`      
                                                                           | A 
percentage (0-100). A datanode is considered balanced if for each volume, its 
utilization differs from the average datanode utilization by no more than this 
threshold. |
-| `hdds.datanode.disk.balancer.max.disk.throughputInMBPerSec` | `10`           
                                                                        | The 
maximum bandwidth (in MB/s) that the balancer can use for moving data, to avoid 
impacting client I/O.                                                           
      |
-| `hdds.datanode.disk.balancer.parallel.thread`               | `5`            
                                                                        | The 
number of worker threads to use for moving containers in parallel.              
                                                                                
      |
-| `hdds.datanode.disk.balancer.service.interval`              | `60s`          
                                                                        | The 
time interval at which the Datanode DiskBalancer service checks for imbalance 
and updates its configuration.                                                  
        |
-| `hdds.datanode.disk.balancer.stop.after.disk.even`          | `true`         
                                                                        | If 
true, the DiskBalancer will automatically stop its balancing activity once 
disks are considered balanced (i.e., all volume densities are within the 
threshold).        |
-| `hdds.datanode.disk.balancer.replica.deletion.delay`       | `5m`            
                                                                       | The 
delay after a container is successfully moved from source volume to destination 
volume before the source container replica is deleted. This lazy deletion 
provides a grace period before failing the read thread holding the old 
container replica. Unit: ns, ms, s, m, h, d. |
-| `hdds.datanode.disk.balancer.container.choosing.policy` | 
`org.apache.hadoop.ozone.container.diskbalancer.policy.DefaultContainerChoosingPolicy`
 | The policy for selecting source/destination volumes and which containers to 
move.                                                                           
              |
-| `hdds.datanode.disk.balancer.service.timeout`               | `300s`         
                                                                        | 
Timeout for the Datanode DiskBalancer service operations.                       
                                                                                
          |
-| `hdds.datanode.disk.balancer.should.run.default`            | `false`        
                                                                        | If 
the balancer fails to read its persisted configuration, this value determines 
if the service should run by default.                                           
         |
+| Property                                                       | Default 
Value                                                                          
| Description                                                                   
                                                                                
                                                                                
                                                                                
         |
+|----------------------------------------------------------------|----------------------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| `hdds.datanode.disk.balancer.enabled`                          | `false`     
                                                                           | If 
false, the DiskBalancer service on the Datanode is disabled. Configure it to 
true for diskBalancer to be enabled.                                            
                                                                                
                                                                                
       |
+| `hdds.datanode.disk.balancer.volume.density.threshold.percent` | `10.0`      
                                                                           | A 
percentage (0-100). A datanode is considered balanced if for each volume, its 
utilization differs from the average datanode utilization by no more than this 
threshold.                                                                      
                                                                                
        |
+| `hdds.datanode.disk.balancer.max.disk.throughputInMBPerSec`    | `10`        
                                                                           | 
The maximum bandwidth (in MB/s) that the balancer can use for moving data, to 
avoid impacting client I/O.                                                     
                                                                                
                                                                                
         |
+| `hdds.datanode.disk.balancer.parallel.thread`                  | `5`         
                                                                           | 
The number of worker threads to use for moving containers in parallel.          
                                                                                
                                                                                
                                                                                
       |
+| `hdds.datanode.disk.balancer.service.interval`                 | `60s`       
                                                                           | 
The time interval at which the Datanode DiskBalancer service checks for 
imbalance and updates its configuration.                                        
                                                                                
                                                                                
               |
+| `hdds.datanode.disk.balancer.stop.after.disk.even`             | `true`      
                                                                           | If 
true, the DiskBalancer will automatically stop its balancing activity once 
disks are considered balanced (i.e., all volume densities are within the 
threshold).                                                                     
                                                                                
                |
+| `hdds.datanode.disk.balancer.replica.deletion.delay`           | `5m`        
                                                                           | 
The delay after a container is successfully moved from source volume to 
destination volume before the source container replica is deleted. This lazy 
deletion provides a grace period before failing the read thread holding the old 
container replica. Unit: ns, ms, s, m, h, d.                                    
                  |
+| `hdds.datanode.disk.balancer.container.states`                 | 
`CLOSED,QUASI_CLOSED`                                                           
       | Comma-separated container lifecycle state names that may be moved 
between disks (must match enum names exactly, uppercase). Default includes 
**CLOSED** and **QUASI_CLOSED**; extend the list when additional states are 
needed to be balanced. All defined container states are OPEN, CLOSING, 
QUASI_CLOSED, CLOSED, UNHEALTHY, INVALID, DELETED, RECOVERING. |

Review Comment:
   "Command Options" needs update too. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to