errose28 commented on code in PR #10032:
URL: https://github.com/apache/ozone/pull/10032#discussion_r3120235015


##########
hadoop-ozone/dist/src/main/compose/upgrade/compose/ha/docker-compose.yaml:
##########
@@ -281,6 +281,29 @@ services:
       - *krb5conf
       - *ozone-dir
       - *transformation
+  upgrade_client:

Review Comment:
   Here we are using a fixed new client version for the whole test. Previously 
with non-rolling upgrade the client and server were upgraded at the same time. 
The previous rolling upgrade workaround would switch to the new client version 
partway through when the SCM was upgraded. We do need to end up on the new 
client version before the server is finalized to test behavior of the new APIs.
   
   I think we may want something in between, where this container starts in the 
old version, and the driver updates it to the new version after all the server 
side components are upgraded but before they are finalized.
   
   Suggesting a more generic name since the current one implies that it is only 
used for upgrade related commands, not all test operations.
   ```suggestion
     client:
   ```



##########
hadoop-ozone/dist/src/main/compose/upgrade/compose/ha/docker-compose.yaml:
##########
@@ -281,6 +281,29 @@ services:
       - *krb5conf
       - *ozone-dir
       - *transformation
+  upgrade_client:
+    command: ["tail", "-f", "/dev/null"]

Review Comment:
   The xcompat tests use `command: ["sleep","1000000"]` to keep the container 
alive indefinitely. This works too, but we might want to make them consistent. 
I'm not sure if one would be better than the other.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to