fapifta commented on code in PR #10111:
URL: https://github.com/apache/ozone/pull/10111#discussion_r3131345386
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/http/HttpServer2.java:
##########
@@ -565,17 +573,59 @@ private ServerConnector createHttpsChannelConnector(
sslContextFactory.setTrustStorePassword(trustStorePassword);
}
}
- if (null != excludeCiphers && !excludeCiphers.isEmpty()) {
+ if (excludeCiphers != null && !excludeCiphers.isEmpty()) {
Review Comment:
I respectfully disagree, this is the only condition which uses the yoda
style, I think this is a better way as it conforms with the rest of the
surrounding code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]