devmadhuu commented on code in PR #9994:
URL: https://github.com/apache/ozone/pull/9994#discussion_r3135754809


##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerEndpoint.java:
##########
@@ -450,6 +458,65 @@ private Response getUnhealthyContainersFromSchema(
     return Response.ok(response).build();
   }
 
+  /**
+   * Export all unhealthy containers into a CSV file by streaming the results 
directly
+   * from the database without holding them in the JVM heap.
+   *
+   * @param state The container state to filter by, or null for all.
+   * @param limit The maximum number of records to return, 0 for unlimited.
+   * @return {@link Response} containing the CSV StreamingOutput.
+   */
+  @GET
+  @Path("/unhealthy/export")
+  @Produces("text/csv")
+  public Response exportUnhealthyContainers(
+      @QueryParam("state") String state,
+      @DefaultValue("0") @QueryParam(RECON_QUERY_LIMIT) int limit) {

Review Comment:
   Few additional cons with this approach:
   
   1. Ties up a Recon server thread for the entire duration. Recon runs on an 
embedded Jetty instance with a bounded thread pool. A 9-minute or more time 
taken export occupies one worker thread for its entire duration. Three 
concurrent admin exports block three threads indefinitely.
   2. Derby connection held open for 9+ minutes. Derby is a single-node 
embedded database. A cursor held open for 9 minutes under concurrent Recon 
read/write traffic is a locking risk.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to