dombizita commented on code in PR #10084:
URL: https://github.com/apache/ozone/pull/10084#discussion_r3137714223
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/server/TestSCMClientProtocolServer.java:
##########
@@ -138,6 +140,80 @@ public void testScmListContainer() throws Exception {
HddsProtos.ReplicationFactor.THREE).getContainerInfoList().size());
}
+ @Test
Review Comment:
Yes, after the above suggested changes (and even before) these tests are
unnecessary. I didn't find unit tests for `queryUpgradeFinalizationProgress`
either, so I added a simple test for `queryUpgradeStatus`, the rest can be
covered with integration tests in the ZDU tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]