Russole commented on code in PR #10120:
URL: https://github.com/apache/ozone/pull/10120#discussion_r3143887616
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/AbstractRootedOzoneFileSystemTest.java:
##########
@@ -1731,45 +1731,36 @@ private void checkInvalidPath(Path path) {
@Test
void testRenameFile() throws Exception {
final String dir = "/dir" + RandomUtils.secure().randomInt(0, 1000);
- Path dirPath = new Path(getBucketPath() + dir);
- Path file1Source = new Path(getBucketPath() + dir
- + "/file1_Copy");
- Path file1Destin = new Path(getBucketPath() + dir + "/file1");
+ Path dirPath = pathUnderFsRoot(dir);
try {
- getFs().mkdirs(dirPath);
-
- ContractTestUtils.touch(getFs(), file1Source);
- assertTrue(getFs().rename(file1Source, file1Destin), "Renamed failed");
- assertTrue(getFs().exists(file1Destin), "Renamed failed: /dir/file1");
- FileStatus[] fStatus = getFs().listStatus(dirPath);
- assertEquals(1, fStatus.length, "Renamed failed");
+ renameFile(dir);
} finally {
// clean up
fs.delete(dirPath, true);
}
}
-
+ @Override
+ void verifyRenameFile(Path workDir, Path expectedDest) throws IOException {
+ FileStatus[] fStatus = getFs().listStatus(workDir);
+ assertEquals(1, fStatus.length, "Renamed failed");
+ }
Review Comment:
Could we also verify `expectedDest` here, or add a short comment explaining
why `RootedOzoneFileSystem` only checks the number of entries? Since
`expectedDest` is passed from the base helper, skipping the path assertion
looks a bit unclear to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]