adoroszlai commented on code in PR #10114:
URL: https://github.com/apache/ozone/pull/10114#discussion_r3153590866
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/XceiverServerGrpc.java:
##########
@@ -145,6 +145,12 @@ public XceiverServerGrpc(DatanodeDetails datanodeDetails,
caClient.getKeyManager());
SslContextBuilder sslContextBuilder = GrpcSslContexts.configure(
sslClientContextBuilder, secConf.getGrpcSslProvider());
+ if (secConf.getGrpcTlsProtocols() != null) {
+ sslContextBuilder.protocols(secConf.getGrpcTlsProtocols());
+ }
+ if (secConf.getGrpcTlsCiphers() != null) {
+ sslContextBuilder.ciphers(secConf.getGrpcTlsCiphers());
+ }
Review Comment:
`SslContextBuilder` handles `null` (meaning "uses default cipher
suites/protocols"), so we can omit null checks in all users of these new
configs.
https://github.com/netty/netty/blob/a169ebbac8c2f86bfa43f79f9954a70733aa2af9/handler/src/main/java/io/netty/handler/ssl/SslContextBuilder.java#L514-L531
https://github.com/netty/netty/blob/a169ebbac8c2f86bfa43f79f9954a70733aa2af9/handler/src/main/java/io/netty/handler/ssl/SslContextBuilder.java#L567-L584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
