smengcl commented on PR #10167: URL: https://github.com/apache/ozone/pull/10167#issuecomment-4373366003
> This is doing writes to the DB, therefore it should be under `ozone repair`, not `ozone debug`. > > What is the use case for adding this? It is a dangerous command to have available on all column families when many have no valid reason to be dropped. If there is a specific issue that this is aiming to recover from, we should create a dedicated repair tool for that issue instead opening up deletion of all RocksDB data. Hey @errose28 , this is not intended to be a repair tool. It belongs to troubleshooting when we are trying to load a RocksDB from another cluster but we don't have the snapshot DBs. Most of the times we won't have rocksdb tools binary handy for that cluster. rocksdbjni already has it but doesn't expose it. This is no more dangerous than admin deleting the ozone metadata by accident TBH. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
