ashishkumar50 commented on code in PR #10054:
URL: https://github.com/apache/ozone/pull/10054#discussion_r3186254708
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -285,25 +290,36 @@ public class DatanodeConfiguration extends
ReconfigurableConfig {
defaultValue = "-1",
type = ConfigType.SIZE,
tags = { OZONE, CONTAINER, STORAGE, MANAGEMENT },
- description = "This determines the free space to be used for closing
containers" +
- " When the difference between volume capacity and used reaches this
number," +
- " containers that reside on this volume will be closed and no new
containers" +
- " would be allocated on this volume." +
- " Max of min.free.space and min.free.space.percent will be used as
final value."
+ description = "Minimum free space (bytes) applied together with
min.free.space.percent "
+ + "(reported to SCM in heartbeat as freeSpaceToSpare) and "
+ + "min.free.space.hard.limit.percent (local write enforcement). "
+ + "The effective value for each tier is max(this bytes, capacity *
ratio)."
)
private long minFreeSpace = getDefaultFreeSpace();
@Config(key = "hdds.datanode.volume.min.free.space.percent",
defaultValue = "0.02", // match
HDDS_DATANODE_VOLUME_MIN_FREE_SPACE_PERCENT_DEFAULT
type = ConfigType.FLOAT,
tags = { OZONE, CONTAINER, STORAGE, MANAGEMENT },
- description = "This determines the free space percent to be used for
closing containers" +
- " When the difference between volume capacity and used reaches
(free.space.percent of volume capacity)," +
- " containers that reside on this volume will be closed and no new
containers" +
- " would be allocated on this volume." +
- " Max of min.free.space or min.free.space.percent will be used as
final value."
+ description = "Minimum fraction of volume capacity reported to SCM as
freeSpaceToSpare "
+ + "(heartbeat / storage reports). Local write rejection uses "
+ + "hdds.datanode.volume.min.free.space.hard.limit.percent instead. "
+ + "The soft band is the gap between these two (e.g. 2000GB disk: 2%
= 40GB reported vs "
+ + "1.5% = 30GB hard → 10GB band) where the DN may send
close-container actions while "
+ + "writes still succeed."
)
private float minFreeSpaceRatio =
HDDS_DATANODE_VOLUME_MIN_FREE_SPACE_PERCENT_DEFAULT;
+ @Config(key = "hdds.datanode.volume.min.free.space.hard.limit.percent",
+ defaultValue = "0.015",
+ type = ConfigType.FLOAT,
+ tags = { OZONE, CONTAINER, STORAGE, MANAGEMENT },
+ description = "Minimum fraction of volume capacity reserved for local
enforcement: "
Review Comment:
Updated the doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
