ashishkumar50 commented on PR #10000: URL: https://github.com/apache/ozone/pull/10000#issuecomment-4378389820
> > ... hasEnoughSpace and recordPendingAllocation methods as we need this during replication which is used by placement policy for space check. ... > > @ashishkumar50 , hasEnoughSpace is unusable since it only checks the space but not updates the value. It will have synchronization issue similar to [#10000 (comment)](https://github.com/apache/ozone/pull/10000#discussion_r3162988799) I have removed for `hasEnoughSpace,` from this PR but as i said we need it for placement policy which is used by replication. I wanted to allow placement policy to use `hasEnoughSpace` and RM to use `checkSpaceAndAdd`. Because placement policy doesn't require container for checking space availability for a DN. We can discuss more about this in [HDDS-14924](https://issues.apache.org/jira/browse/HDDS-14924). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
