jojochuang commented on code in PR #10165:
URL: https://github.com/apache/ozone/pull/10165#discussion_r3190464267
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/http/HttpServer2.java:
##########
@@ -596,18 +596,16 @@ private ServerConnector createHttpsChannelConnector(
private void setEnabledProtocols(SslContextFactory sslContextFactory) {
String enabledProtocols =
conf.get(OzoneConfigKeys.OZONE_SSL_ENABLED_PROTOCOLS,
conf.get(SSLFactory.SSL_ENABLED_PROTOCOLS_KEY,
SSLFactory.SSL_ENABLED_PROTOCOLS_DEFAULT));
- if (!enabledProtocols.equals(SSLFactory.SSL_ENABLED_PROTOCOLS_DEFAULT)) {
- List<String> originalExcludedProtocols =
Arrays.asList(sslContextFactory.getExcludeProtocols());
- String[] enabledProtocolsArray =
StringUtils.getTrimmedStrings(enabledProtocols);
+ List<String> originalExcludedProtocols =
Arrays.asList(sslContextFactory.getExcludeProtocols());
+ String[] enabledProtocolsArray =
StringUtils.getTrimmedStrings(enabledProtocols);
- List<String> finalExcludedProtocols = new
ArrayList<>(originalExcludedProtocols);
- finalExcludedProtocols.removeAll(Arrays.asList(enabledProtocolsArray));
+ List<String> finalExcludedProtocols = new
ArrayList<>(originalExcludedProtocols);
+ finalExcludedProtocols.removeAll(Arrays.asList(enabledProtocolsArray));
Review Comment:
IIRC it is a Jetty specific semantics. Yes, exclude list takes precendece
over white list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
