adoroszlai commented on code in PR #10160:
URL: https://github.com/apache/ozone/pull/10160#discussion_r3206817275
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java:
##########
@@ -106,21 +113,24 @@ private void printBreak() {
}
}
- private void printDetails(ScmClient scmClient, long containerID) throws
IOException {
+ private boolean printDetails(ScmClient scmClient, long containerID) throws
IOException {
Review Comment:
This change is no longer needed.
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/container/ReconcileSubcommand.java:
##########
@@ -55,6 +56,15 @@ public class ReconcileSubcommand extends ScmSubcommand {
description = "Display the reconciliation status of this container's
replicas")
private boolean status;
+ private enum StatusProcessing {
+ OK,
+ FAILED_CONTINUE
+ }
Review Comment:
`enum StatusProcessing` is no longer needed.
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/container/ReconcileSubcommand.java:
##########
@@ -150,7 +166,12 @@ private void executeReconcile(ScmClient scmClient) {
* display that to the user.
*/
private String getExceptionMessage(Exception ex) {
+ String aclLine = HddsUtils.formatAccessControlExceptionLine(ex);
+ if (aclLine != null) {
+ return aclLine;
+ }
Review Comment:
This is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
