priyeshkaratha commented on code in PR #9915: URL: https://github.com/apache/ozone/pull/9915#discussion_r3210195726
########## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/chatbot/security/LLMClient2.java: ########## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.ozone.recon.chatbot.security; + +import java.util.List; +import java.util.Map; + +/** + * LLMClient is the "Master Contract" for the whole Chatbot system. + * + * Purpose: + * The ChatbotAgent doesn't know (or care) if it's talking to OpenAI, Gemini, or a Local LLM. + * It strictly relies on this interface. This interface forces every AI client to guarantee + * that they will accept exactly the same input and return exactly the same output. + * + * By using this contract, we can add 10 new AI models to Recon tomorrow, + * and we will never have to edit the ChatbotAgent's code to support them! + */ +public interface LLMClient2 { Review Comment: This file seems like duplicate of org.apache.hadoop.ozone.recon.chatbot.llm.LLMClient -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
