YutaLin commented on PR #10218: URL: https://github.com/apache/ozone/pull/10218#issuecomment-4411515699
> @YutaLin I’d actually suggest not fixing this. The underlying problem is that if a follower has an incomplete snapshot create request, it’s impossible to fully prevent its in-flight snapshot counter from going below 0. Because of that, we need to keep the “don’t decrease if the in-flight count goes below 0” workaround. HI @peterxcli, thanks for review! I know it’s impossible to fully fix the reset logic because it’s an in-flight snapshot counter, but we can still improve the snapshot check logic to make it more robust. This is noted in the PR description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
