henrybear327 commented on PR #10147:
URL: https://github.com/apache/ozone/pull/10147#issuecomment-4416512982
> Thanks @henrybear327 for the patch.
>
> Please consider leveraging PicoCLI's built-in environment variable support
(e.g., @option(..., defaultValue = "${env:OZONE_LOCAL_DATANODES:-1}")). This
automatically handles type binding and validation for us, which could help
remove a lot of boilerplate code in resolveConfig. It might keep the code much
cleaner and simpler. See https://picocli.info/#_variables_in_default_values.
Thank you for the feedback! Addressed in the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
