adoroszlai commented on code in PR #10230:
URL: https://github.com/apache/ozone/pull/10230#discussion_r3216824082
##########
hadoop-hdds/client/dev-support/findbugsExcludeFile.xml:
##########
@@ -19,4 +19,13 @@
<Class name="org.apache.hadoop.hdds.scm.storage.ByteArrayReader"></Class>
<Bug pattern="EI_EXPOSE_REP2" /> <!-- "Deep copy byte[] has bad impact on
performance" -->
</Match>
+ <Match>
+ <!--
+ Required until we have https://github.com/spotbugs/spotbugs/pull/3410
(SpotBugs 4.8)
+ FakeDatanodePipeline Line
"doReturn(pipeline).when(xceiverClient).getPipeline();" (115 at time of this
addition
+ is reported but is a false positive.
Review Comment:
The statement can be replaced with:
```
when(xceiverClient.getPipeline()).thenReturn(pipeline);
```
to avoid the need for findbugs exclusion.
See also HDDS-12472.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
