Copilot commented on code in PR #10208:
URL: https://github.com/apache/ozone/pull/10208#discussion_r3230120058
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java:
##########
@@ -2676,6 +2676,7 @@ public String getQuotaRepairStatus() throws IOException {
public void startQuotaRepair(List<String> buckets) throws IOException {
OzoneManagerProtocolProtos.StartQuotaRepairRequest startQuotaRepairRequest
=
OzoneManagerProtocolProtos.StartQuotaRepairRequest.newBuilder()
+ .addAllBuckets(buckets)
.build();
Review Comment:
`addAllBuckets(buckets)` will throw a NullPointerException if callers pass
`null`. Previously `startQuotaRepair(null)` would have worked (it just sent an
empty request), so this is a behavior change that can break existing callers.
Consider explicitly handling `null` (treat as empty list) or validate with a
clear precondition/exception, and add a unit test covering the chosen behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
