adoroszlai commented on code in PR #10261: URL: https://github.com/apache/ozone/pull/10261#discussion_r3235202161
########## .github/workflows/pr-diff-coverage.yml: ########## @@ -0,0 +1,66 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +name: PR Diff Coverage Verification + +on: + pull_request: + types: [opened, synchronize, reopened] + +permissions: + pull-requests: write + contents: read + +jobs: + analyze-diff-coverage: + runs-on: ubuntu-latest + + steps: + # Step 1: Checkout the repo with full git history (depth: 0) + # This is crucial so the action can compare the PR branch against the target branch + - name: Checkout Codebase + uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 + with: + fetch-depth: 0 + + # Step 2: Provision Java Runtime Environment + - name: Set up JDK 17 + uses: actions/setup-java@3a4f6e1af504cf6a31855fa899c6aa5355ba6c12 + with: + java-version: '17' + distribution: 'temurin' + cache: 'maven' + + # Step 3: Compile and run tests to generate target/site/jacoco/jacoco.xml + - name: Execute Tests and Generate Reports + run: mvn clean test Review Comment: We cannot add this, because: - Running all tests in a single go takes several hours. That's why we run tests in splits. - It duplicates work already being done in the _integration_ check. - It will result in unexpectedly low coverage, since acceptance tests are completely ignored. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
