sreejasahithi commented on code in PR #10255:
URL: https://github.com/apache/ozone/pull/10255#discussion_r3245960116
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/container/TestContainerReportHandling.java:
##########
@@ -63,32 +67,63 @@ public class TestContainerReportHandling {
private static final String VOLUME = "vol1";
private static final String BUCKET = "bucket1";
private static final String KEY = "key1";
+
+ private enum ReplicationInput {
+ RATIS(3, RatisReplicationConfig.getInstance(THREE)),
+ EC(5, new ECReplicationConfig(3, 2));
+
+ private final int numDatanodes;
+ private final ReplicationConfig replicationConfig;
+
+ ReplicationInput(int numDatanodes, ReplicationConfig replicationConfig) {
+ this.numDatanodes = numDatanodes;
+ this.replicationConfig = replicationConfig;
Review Comment:
ReplicationInput is the same enum used in TestContainerReportHandling.java
and TestContainerReportHandlingWithHA.java, would it be better to extracted to
a shared test utility class.
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/TestContainerStateManager.java:
##########
@@ -322,8 +324,8 @@ public void
testDeletedECContainerWithStaleClosedReplicaShouldNotForceDelete()
// Verify delete command sent
sendReportAndCaptureDeleteCommand(ecContainer, datanode,
ecContainer.getSequenceId(), false, 1, true);
- // Container should remain as DELETED
- verifyContainerState(ecContainer.containerID(),
HddsProtos.LifeCycleState.DELETED);
+ // Container should be deleted
+ verifyContainerState(ecContainer.containerID(), state);
Review Comment:
Here verify that the delete command sent is force delete command, similar to
other tests in this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
