ChenSammi commented on PR #10305: URL: https://github.com/apache/ozone/pull/10305#issuecomment-4495311996
> @ChenSammi thanks for updating the patch > > Since download happens only when `native`/`native-mac` profile is enabled, this is not tested by CI. I still think we should download _all_ libs in `dist` profile (i.e. I suggest removing new profiles). Linking platform-specific lib should happen at runtime (remove existing link if exists and does not match platform), in `ozone` or before unit/integration tests (`process-test-resources` phase?) if you want to use it in JUnit tests. Can I keep the current two profiles in this patch since it works correctly now? I will try to do the suggested refactor once I move on to the unit test patch to see if it works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
