adoroszlai opened a new pull request, #10317: URL: https://github.com/apache/ozone/pull/10317
## What changes were proposed in this pull request? Sleep period in `RetryInvocationHandler` should be `waitTime`, not `delay` (see https://github.com/apache/ozone/pull/10310#discussion_r3267263810). 1. `RetryInfo.retryTime` is calculated when it is created: https://github.com/apache/ozone/blob/c917a6e60d36e0c5b628ab93cc80feaf10c590ff/hadoop-hdds/common/src/main/java/org/apache/hadoop/io_/retry/RetryInvocationHandler.java#L253-L254 2. `waitTime` is calculated before `sleep` as: https://github.com/apache/ozone/blob/c917a6e60d36e0c5b628ab93cc80feaf10c590ff/hadoop-hdds/common/src/main/java/org/apache/hadoop/io_/retry/RetryInvocationHandler.java#L85-L86 3. but then original `RetryInfo.delay` is used for actual sleep time: https://github.com/apache/ozone/blob/c917a6e60d36e0c5b628ab93cc80feaf10c590ff/hadoop-hdds/common/src/main/java/org/apache/hadoop/io_/retry/RetryInvocationHandler.java#L131-L136 Since this is such a small change, also make some improvements in this area: - Remove some leftover references to async call handling - Port `TestRetryProxy` from Hadoop - Change `test-client` profile in `pom.xml` to include tests ported from Hadoop (more tests to come in follow-up PRs) https://issues.apache.org/jira/browse/HDDS-15328 ## How was this patch tested? ``` Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.274 s -- in org.apache.hadoop.io_.retry.TestRetryProxy ``` https://github.com/adoroszlai/ozone/actions/runs/26150721145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
