Gargi-jais11 commented on code in PR #10308:
URL: https://github.com/apache/ozone/pull/10308#discussion_r3278539336
##########
hadoop-ozone/cli-admin/src/test/java/org/apache/hadoop/hdds/scm/cli/datanode/TestDiskBalancerSubCommands.java:
##########
@@ -590,6 +595,45 @@ public void testStatusDiskBalancerWithStdin() throws
Exception {
// ========== DiskBalancerReportSubcommand Tests ==========
+ static Stream<Arguments> thresholdRangeReportCases() {
+ return Stream.of(
+ Arguments.of(0.08426521, 10.0, false,
+ "ThresholdRange: (0.00000000, 0.18426521)", "ThresholdRange: (-"),
+ Arguments.of(0.95, 10.0, false,
+ "ThresholdRange: (0.85000000, 1.00000000)", "1.05000000"),
+ Arguments.of(0.95, 10.0, true,
+ "\"thresholdRange\" : \"(0.85000000, 1.00000000)\"",
"1.05000000"));
Review Comment:
we need unclamped value in test case to see it does clamping of threshold.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
