xichen01 commented on PR #10303: URL: https://github.com/apache/ozone/pull/10303#issuecomment-4505435381
> Hey, thanks for the PR - all looks good. > > The PR introduces a couple of intermediate scaffolds (the storageType == null branch in KeyValueContainer.create and the default overload on Container.create); they presumably get cleaned up later in the [HDDS-11233](https://issues.apache.org/jira/browse/HDDS-11233) series. > > Could you note that in the PR description — even a short "intermediate state; will be removed in patches N/M" line — so future reviewers don't have to reconstruct it? I added some comments for this in the code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
