smengcl commented on code in PR #10185:
URL: https://github.com/apache/ozone/pull/10185#discussion_r3284690015
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/ratis_snapshot/TestOmRatisSnapshotProvider.java:
##########
@@ -80,6 +87,46 @@ public void setup(@TempDir File snapshotDir,
false, connectionFactory);
}
+ @Test
+ public void testIsDiskFullOrQuotaIOExceptionDetectsNoSpaceMessage() {
+ assertTrue(OmRatisSnapshotProvider.isDiskFullOrQuotaIOException(
+ new IOException("No space left on device")));
+ }
+
+ @Test
+ public void
testIsDiskFullOrQuotaIOExceptionDetectsFileSystemExceptionReason() {
+ IOException wrapped = new IOException("write failed",
+ new FileSystemException("p", null, "No space left on device"));
+ assertTrue(OmRatisSnapshotProvider.isDiskFullOrQuotaIOException(wrapped));
+ }
+
+ @Test
+ public void testIsDiskFullOrQuotaIOExceptionReturnsFalseForOtherErrors() {
+ assertFalse(OmRatisSnapshotProvider.isDiskFullOrQuotaIOException(
+ new IOException("Connection reset")));
+ }
+
+ @Test
+ public void testBootstrapDiskSpaceCheckSkippedWhenZero(@TempDir File
snapshotDir) {
+ OzoneConfiguration conf = new OzoneConfiguration();
+ conf.set(OMConfigKeys.OZONE_OM_BOOTSTRAP_MIN_SPACE_KEY, "0GB");
+ OmRatisSnapshotProvider provider =
+ new OmRatisSnapshotProvider(conf, snapshotDir, new HashMap<>());
+ assertDoesNotThrow(() -> provider.ensureBootstrapDiskSpace());
+ }
+
+ @Test
+ public void testBootstrapDiskSpaceCheckFailsWhenBelowMinimum(@TempDir File
snapshotDir) {
+ OzoneConfiguration conf = new OzoneConfiguration();
+ conf.set(OMConfigKeys.OZONE_OM_BOOTSTRAP_MIN_SPACE_KEY, "1024EB");
+ OmRatisSnapshotProvider provider =
+ new OmRatisSnapshotProvider(conf, snapshotDir, new HashMap<>());
+ IOException ex =
+ assertThrows(IOException.class, provider::ensureBootstrapDiskSpace);
+ assertEquals(true,
+
ex.getMessage().contains(OMConfigKeys.OZONE_OM_BOOTSTRAP_MIN_SPACE_KEY));
Review Comment:
nit: use `assertThat(<string>).contains(...)` instead. See HDDS-9951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
