peterxcli commented on code in PR #10333:
URL: https://github.com/apache/ozone/pull/10333#discussion_r3294278847
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java:
##########
@@ -443,8 +443,7 @@ public BackgroundTaskQueue getTasks() {
destVolume);
queue.add(task);
inProgressContainers.add(ContainerID.valueOf(toBalanceContainer.getContainerID()));
- deltaSizes.put(sourceVolume, deltaSizes.getOrDefault(sourceVolume,
0L)
- - toBalanceContainer.getBytesUsed());
+ reserveDeltaSize(sourceVolume, toBalanceContainer.getBytesUsed());
Review Comment:
```suggestion
deltaSizes.merge(sourceVolume, -toBalanceContainer.getBytesUsed(),
Long::sum);
```
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java:
##########
@@ -654,8 +691,7 @@ public int getPriority() {
private void postCall(boolean success, long startTime) {
inProgressContainers.remove(ContainerID.valueOf(containerData.getContainerID()));
- deltaSizes.put(sourceVolume, deltaSizes.get(sourceVolume) +
- containerData.getBytesUsed());
+ releaseDeltaSize(sourceVolume, containerData.getBytesUsed());
Review Comment:
or
```java
deltaSizes.merge(sourceVolume, containerData.getBytesUsed(),(current, bytes)
-> current + bytes);
```
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java:
##########
@@ -654,8 +691,7 @@ public int getPriority() {
private void postCall(boolean success, long startTime) {
inProgressContainers.remove(ContainerID.valueOf(containerData.getContainerID()));
- deltaSizes.put(sourceVolume, deltaSizes.get(sourceVolume) +
- containerData.getBytesUsed());
+ releaseDeltaSize(sourceVolume, containerData.getBytesUsed());
Review Comment:
```suggestion
deltaSizes.merge(sourceVolume, containerData.getBytesUsed(),
Long::sum);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
