adoroszlai commented on code in PR #10348:
URL: https://github.com/apache/ozone/pull/10348#discussion_r3294307033
##########
hadoop-ozone/cli-interactive/src/main/java/org/apache/hadoop/ozone/shell/OzoneInteractiveShell.java:
##########
@@ -29,24 +30,18 @@
*/
public final class OzoneInteractiveShell {
- private static final Logger LOG =
LoggerFactory.getLogger(OzoneInteractiveShell.class);
-
private OzoneInteractiveShell() {
}
public static void main(String[] argv) throws Exception {
PicocliCommandsFactory factory = new PicocliCommandsFactory();
CommandLine topCmd = new CommandLine(new TopCommand(), factory);
- // Add known subcommands statically if they are in the same module.
topCmd.addSubcommand("sh", new OzoneShell().getCmd());
- topCmd.addSubcommand("tenant", new
org.apache.hadoop.ozone.shell.tenant.TenantShell().getCmd());
- topCmd.addSubcommand("s3", new
org.apache.hadoop.ozone.shell.s3.S3Shell().getCmd());
-
- // Dynamically add subcommands from other modules to avoid circular
dependencies.
- addDynamicSubcommand(topCmd, "admin",
"org.apache.hadoop.ozone.admin.OzoneAdmin");
- addDynamicSubcommand(topCmd, "debug",
"org.apache.hadoop.ozone.debug.OzoneDebug");
- addDynamicSubcommand(topCmd, "repair",
"org.apache.hadoop.ozone.repair.OzoneRepair");
Review Comment:
Repair commands are "dangerous" and most need to be run with components (OM,
etc.) stopped. I don't think they should be mixed with other commands. I
can't remember a more specific reason for adding it as exception in HDDS-15185
description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
