Russole commented on code in PR #10336:
URL: https://github.com/apache/ozone/pull/10336#discussion_r3294992507
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/ha/invoker/ScmInvokerCodeGenerator.java:
##########
@@ -607,15 +611,17 @@ public String generateClass() {
return out.toString();
}
- File updateFile(String classString) throws IOException {
- final File java = new File(DIR, invokerClassName + ".java");
+ File updateFile(String classString, String dir, boolean overwrite) throws
IOException {
+ final File java = new File(dir, invokerClassName + ".java");
if (!java.isFile()) {
throw new FileNotFoundException("Not found: " + java.getAbsolutePath());
}
- final File tmp = new File(DIR, invokerClassName + "_tmp.java");
+ final File tmp = new File(dir, invokerClassName + "_tmp.java");
if (tmp.exists()) {
throw new IOException("Already exist: " + java.getAbsolutePath());
Review Comment:
Although this was not introduced in this PR, since this method is being
touched, should this error message use `tmp.getAbsolutePath()` instead of
`java.getAbsolutePath()` ? The file that already exists here is tmp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
