YutaLin commented on code in PR #10361:
URL: https://github.com/apache/ozone/pull/10361#discussion_r3301171534
##########
hadoop-ozone/interface-storage/src/test/java/org/apache/hadoop/ozone/om/helpers/TestOmKeyInfoCodec.java:
##########
@@ -115,11 +116,11 @@ public void testOmKeyInfoCodecWithoutPipeline(int
chunkNum)
}
public void testOmKeyInfoCodecCompatibility(int chunkNum) throws IOException
{
- final Codec<OmKeyInfo> codecWithoutPipeline = OmKeyInfo.getCodec(true);
- final Codec<OmKeyInfo> codecWithPipeline = OmKeyInfo.getCodec(false);
+ final Codec<OmKeyInfo> codec = OmKeyInfo.getCodec();
OmKeyInfo originKey = getKeyInfo(chunkNum);
- byte[] rawData = codecWithPipeline.toPersistedFormat(originKey);
- OmKeyInfo key = codecWithoutPipeline.fromPersistedFormat(rawData);
+ byte[] rawData = originKey
Review Comment:
Hi @peterxcli, thanks for the review!
I am not sure what "compatibility problem" you are referring to.
AFAIK, we don't persist pipeline info because pipeline it can change over
time. We re-fetched from SCM when we needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
