priyeshkaratha commented on PR #10304: URL: https://github.com/apache/ozone/pull/10304#issuecomment-4590768830
@devmadhuu Thanks for the review. I have addressed all the three points in latest changes > 3. If we are removing the `TotalCapacity` , then did you verify if any grafana dashboards/alerts scrapes that jmx metric name anywhere ? Just make sure that it doesn't cause regression. Yes, verified this. > 4. JMX exposes soft `MinFreeSpace` (`getReportedFreeSpaceToSpare`). Write path rejection uses hard `getFreeSpaceToSpare()`. Admin or developers debugging `numWriteRequestsRejectedHardMinFreeSpace` may want both. You want want to do in this or next PR, your call. I will handle this in followup Jira. > Are these metrics available from /prom endpoint as well? @yandrey321 Yes its reflecting prom as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
