[
https://issues.apache.org/jira/browse/HDDS-15344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ren Koike updated HDDS-15344:
-----------------------------
Description:
In *AbstractOzoneFileSystemTest* and *AbstractRootedOzoneFileSystemTest* the
following tests are (almost) identical. These test should be checked if shared
logic are worth moving into {*}OzoneFileSystemTestBase{*}.
||Test||Notes||
|testFileDelete|Almost identical logic; only grandparent path differs
({{{}/{}}} vs {{{}bucketPath{}}}).|
|testCreateWithInvalidPaths|Same checks; differs by assumptions
({{{}FILE_SYSTEM_OPTIMIZED{}}} vs {{{}isBucketFSOptimized{}}}) and helpers.|
|testFileSystemDeclaresCapability|Tiny; path/capabilities differ
({{{}Path("/"){}}} vs {{{}getBucketPath(){}}}).|
|testSetTimes|Same idea (create key, {{{}setTimes{}}}, assert mtime); OFS
creates extra bucket; OFS-only testSetTimesForLinkedBucketPath.|
|testSnapshotRead|Same high-level snapshot listing; wiring/paths differ.|
|testListStatusOnLargeDirectory|Parallel scenario; O3FS uses {{ROOT}}
+{{EXCLUDE_TRASH}}+ {{{}assumeFalse{}}}; OFS uses {{"/vol/buck"}} + no filter.|
|testTrash, testGetTrashRoot, testGetTrashRoots|Same names; behavior and setup
often diverge a lot (worth a cost/benefit pass before extracting).|
was:
||Test||Notes||
|testFileDelete|Almost identical logic; only grandparent path differs
({{{}/{}}} vs {{{}bucketPath{}}}).|
|testCreateWithInvalidPaths|Same checks; differs by assumptions
({{{}FILE_SYSTEM_OPTIMIZED{}}} vs {{{}isBucketFSOptimized{}}}) and helpers.|
|testFileSystemDeclaresCapability|Tiny; path/capabilities differ
({{{}Path("/"){}}} vs {{{}getBucketPath(){}}}).|
|testSetTimes|Same idea (create key, {{{}setTimes{}}}, assert mtime); OFS
creates extra bucket; OFS-only testSetTimesForLinkedBucketPath.|
|testSnapshotRead|Same high-level snapshot listing; wiring/paths differ.|
|testListStatusOnLargeDirectory|Parallel scenario; O3FS uses {{ROOT}} +
{{EXCLUDE_TRASH}} + {{{}assumeFalse{}}}; OFS uses {{"/vol/buck"}} + no filter.|
|testTrash, testGetTrashRoot, testGetTrashRoots|Same names; behavior and setup
often diverge a lot (worth a cost/benefit pass before extracting).|
> Extract test cases to OzoneFileSystemTests part 6
> -------------------------------------------------
>
> Key: HDDS-15344
> URL: https://issues.apache.org/jira/browse/HDDS-15344
> Project: Apache Ozone
> Issue Type: Sub-task
> Reporter: Ren Koike
> Assignee: Ren Koike
> Priority: Major
>
> In *AbstractOzoneFileSystemTest* and *AbstractRootedOzoneFileSystemTest* the
> following tests are (almost) identical. These test should be checked if
> shared logic are worth moving into {*}OzoneFileSystemTestBase{*}.
> ||Test||Notes||
> |testFileDelete|Almost identical logic; only grandparent path differs
> ({{{}/{}}} vs {{{}bucketPath{}}}).|
> |testCreateWithInvalidPaths|Same checks; differs by assumptions
> ({{{}FILE_SYSTEM_OPTIMIZED{}}} vs {{{}isBucketFSOptimized{}}}) and helpers.|
> |testFileSystemDeclaresCapability|Tiny; path/capabilities differ
> ({{{}Path("/"){}}} vs {{{}getBucketPath(){}}}).|
> |testSetTimes|Same idea (create key, {{{}setTimes{}}}, assert mtime); OFS
> creates extra bucket; OFS-only testSetTimesForLinkedBucketPath.|
> |testSnapshotRead|Same high-level snapshot listing; wiring/paths differ.|
> |testListStatusOnLargeDirectory|Parallel scenario; O3FS uses {{ROOT}}
> +{{EXCLUDE_TRASH}}+ {{{}assumeFalse{}}}; OFS uses {{"/vol/buck"}} + no
> filter.|
> |testTrash, testGetTrashRoot, testGetTrashRoots|Same names; behavior and
> setup often diverge a lot (worth a cost/benefit pass before extracting).|
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
