Russole commented on code in PR #10403:
URL: https://github.com/apache/ozone/pull/10403#discussion_r3341698803
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/replication/TestReplicationSupervisor.java:
##########
@@ -1139,6 +1140,37 @@ public void poolSizeCanBeDecreased() {
}
}
+ @ContainerLayoutTestInfo.ContainerTest
+ public void poolSizeCanBeUpdatedByReplicationStreamsLimitReconfiguration() {
+ final int replicationMaxStreams = 5;
+ ReplicationServer.ReplicationConfig repConf =
+ new ReplicationServer.ReplicationConfig();
+ repConf.setReplicationMaxStreams(replicationMaxStreams);
+
+ AtomicInteger threadPoolSize = new AtomicInteger();
+
+ ReplicationSupervisor rs = ReplicationSupervisor.newBuilder()
+ .executor(new DiscardingExecutorService())
+ .executorThreadUpdater(threadPoolSize::set)
+ .replicationConfig(repConf)
+ .build();
+
+ rs.nodeStateUpdated(IN_SERVICE);
+ assertEquals(replicationMaxStreams, threadPoolSize.get());
+
+ rs.setReplicationMaxStreams(7);
+ assertEquals(7, threadPoolSize.get());
+
+ rs.nodeStateUpdated(DECOMMISSIONING);
Review Comment:
Good catch, updated to use the configured factor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
