sreejasahithi commented on code in PR #10414: URL: https://github.com/apache/ozone/pull/10414#discussion_r3354896732
########## hadoop-ozone/cli-debug/src/main/java/org/apache/hadoop/ozone/debug/datanode/container/analyze/AnalyzeSubcommand.java: ########## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.debug.datanode.container.analyze; + +import java.io.IOException; +import java.util.List; +import java.util.Map; +import java.util.concurrent.Callable; +import java.util.stream.Collectors; +import org.apache.hadoop.hdds.cli.AbstractSubcommand; +import org.apache.hadoop.hdds.conf.OzoneConfiguration; +import picocli.CommandLine; +import picocli.CommandLine.Command; + +/** + * {@code ozone debug datanode container analyze}. + * + * <p>Compares on-disk container directories on this DataNode against SCM + * metadata to report inconsistencies. + */ +@Command( + name = "analyze", + description = "Analyze container consistency between on-disk container " + + "directories on this DataNode and SCM metadata. Must be run locally on a DataNode.") +public class AnalyzeSubcommand extends AbstractSubcommand implements Callable<Void> { + @CommandLine.Option(names = {"--count"}, + defaultValue = "20", + description = "Number of containers to display") Review Comment: For now only duplicates are displayed by the command but in future we will show orphan containers wrt SCM and also containers which are marked as DELETED in SCM but their container dir is still present on disk so for the other cases also we will be using the same count. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
