amaliujia commented on code in PR #10451:
URL: https://github.com/apache/ozone/pull/10451#discussion_r3370873659
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMRatisSnapshots.java:
##########
@@ -931,8 +941,6 @@ public void testInstallSnapshotWithClientRead() throws
Exception {
.get(followerOMMetaMngr.getOzoneKey(volumeName, bucketName, key)));
}
- // Wait installation finish
- Thread.sleep(5000);
Review Comment:
Same as above that we can do `GenericTestUtils.waitFor` to wait up to 50
seconds.
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMRatisSnapshots.java:
##########
@@ -169,11 +169,13 @@ public void init(TestInfo testInfo) throws Exception {
clientConfig.setRpcTimeOut(TimeUnit.SECONDS.toMillis(5));
conf.setFromObject(clientConfig);
- cluster = MiniOzoneCluster.newHABuilder(conf)
- .setOMServiceId("om-service-test1")
+ MiniOzoneHAClusterImpl.Builder clusterBuilder =
+ MiniOzoneCluster.newHABuilder(conf);
+ clusterBuilder.setOMServiceId("om-service-test1")
.setNumOfOzoneManagers(NUM_OF_OMS)
.setNumOfActiveOMs(2)
- .build();
+ .setNumDatanodes(1);
+ cluster = clusterBuilder.build();
Review Comment:
Nit:
cluster = MiniOzoneCluster.newHABuilder(conf)
setOMServiceId("om-service-test1")
.setNumOfOzoneManagers(NUM_OF_OMS)
.setNumOfActiveOMs(2)
.build();
.setNumDatanodes(1)
.build()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
