Gargi-jais11 commented on PR #10457: URL: https://github.com/apache/ozone/pull/10457#issuecomment-4645828547
Thanks @slfan1989 for the patch. Few more places left to update in javadoc to be consistent. 1. [DiskBalancerCommands.java](https://github.com/apache/ozone/blob/master/hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DiskBalancerCommands.java) — class-level Javadoc is mixed: **Line 38:** "Commands will only be sent to IN_SERVICE datanodes" contradicts lines 35–36 (which already mention HEALTHY). **Line 80:** JSON example still says "all IN_SERVICE datanodes". **Line 114:** update example still says "all IN_SERVICE datanodes". 2. [DiskBalancerSubCommandUtil.java](https://github.com/apache/ozone/blob/d35338b6616ae47d8dc800b0319d86c34bed44ed/hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DiskBalancerSubCommandUtil.java#L78-L85) — Javadoc on `getAllOperableNodesClientRpcAddress() `says "Retrieves all IN_SERVICE datanode addresses" but the code filters IN_SERVICE and HEALTHY . 3. Docs — user-facing docs still say IN_SERVICE only in several places: `hadoop-hdds/docs/content/feature/DiskBalancer.md` — option table (line ~157) and example comments (lines ~172, 192, 205, 219, 231) `hadoop-hdds/docs/content/feature/DiskBalancer.zh.md` — same sections `hadoop-hdds/docs/content/design/diskbalancer.md `— lines ~72 and ~84–85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
