sodonnel commented on PR #10415: URL: https://github.com/apache/ozone/pull/10415#issuecomment-4651451478
I agree with @yandrey321 that there needs to be some tests here. The Seek logic has various boundary cases, eg: * seek to a position behind the current buffer * seek within the current buffer * seek within the pre-read chunks * seek past all the pre-read chunks * seek to the start * seek out of range The tests should validate data read correctness, and that unnecessary reads are not issued to the server when relevant. To commit this code without tests is not going to help the next person that comes along, and this code is complex enough that its difficult (at least for me) to follow or review the correctness of. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
