bharatviswa504 commented on a change in pull request #2359:
URL: https://github.com/apache/ozone/pull/2359#discussion_r657620148
##########
File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
##########
@@ -2053,6 +2053,14 @@
</description>
</property>
+ <property>
+ <name>ozone.scm.ratis.minimum.timeout</name>
Review comment:
We need to remove this from ozone-default.xml and SCMConfigKeys
And we should change below code where we are using config from SCMConfigKeys
to SCMHAConfiguration. And also change it to 30000ms
```
final long requestTimeout = scm.getConfiguration()
.getTimeDuration(ScmConfigKeys.OZONE_SCM_RATIS_REQUEST_TIMEOUT_KEY,
ScmConfigKeys.OZONE_SCM_RATIS_REQUEST_TIMEOUT_DEFAULT,
TimeUnit.MILLISECONDS);
```
Should be changed as
```
final long requestTimeout =
scm.getConfiguration().getObject(SCMHAConfiguration.class)
.getRatisRequestTimeout();
```
cc @bshashikant to check if it okay to use this here also,as currently it is
being used in
```
Rpc.setRequestTimeout(properties, TimeDuration.valueOf(
conf.getRatisRequestTimeout(), TimeUnit.MILLISECONDS));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
