ivandika3 commented on code in PR #10329:
URL: https://github.com/apache/ozone/pull/10329#discussion_r3378177334
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/acl/OMBucketSetAclRequest.java:
##########
@@ -54,6 +54,7 @@ public class OMBucketSetAclRequest extends OMBucketAclRequest
{
@Override
public OMRequest preExecute(OzoneManager ozoneManager) throws IOException {
+ super.preExecute(ozoneManager);
Review Comment:
This calls `super.preExecute` which checks the `WRITE_ACL` since it is a
SetAcl request, but the other subclasses of `OMBucketAclRequest` (i.e.
`OMBucketRemoveAclRequest` and `OMBucketAddAclRequest`) do not call
`super.perExecute` (they should not call it). Seems awkward.
The `WRITE_ACL` check should remain in `OMBucketSetAclRequest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
