adoroszlai commented on code in PR #10458:
URL: https://github.com/apache/ozone/pull/10458#discussion_r3386551485
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestContainerStateMachine.java:
##########
@@ -108,7 +108,7 @@ public void setup() throws Exception {
cluster.waitForClusterToBeReady();
cluster.waitForPipelineTobeReady(HddsProtos.ReplicationFactor.ONE, 30000);
cluster.getOzoneManager().startSecretManager();
- //the easiest way to create an open container is creating a key
+ // The easiest way to create an open container is creating a key.
Review Comment:
nit: This comment is useless here, since no key is created in `setup()`. It
appears in 19 integration test classes due to copy-paste implementation.
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestContainerStateMachineFailureOnRead.java:
##########
@@ -194,7 +193,7 @@ public void testReadStateMachineFailureClosesPipeline()
throws Exception {
}).findFirst();
assertTrue(leaderDn.isPresent());
- // delete the container dir from leader
+ // Delete the container directory from leader.
Review Comment:
nit: Please don't make unnecessary change in unrelated comments, as it
inflates the patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
