yandrey321 commented on PR #10438: URL: https://github.com/apache/ozone/pull/10438#issuecomment-4680846580
> Actually, the current runTestImpl(..) already testing put(byte[]). Before this change, it is actually testing put(ByteBuffer) since it use ByteBuffer.wrap(..). So, we need new tests for put(ByteBuffer). the idea of the benchmark was to show the performance and memory allocation difference between added put(bytes[], offset, len) vs default implementation via put(ByteBuffer.wrap()) that was used before. It is not generic benchmark for put(bytes[]) vs put(ByteBuffer) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
