kerneltime commented on PR #10486: URL: https://github.com/apache/ozone/pull/10486#issuecomment-4687996963
Addressed Copilot's three findings in the latest force-push: 1. `OMProxyInfo.setCachedAddressForTest` now rejects null via `Objects.requireNonNull`, so a null injection surfaces immediately as a test bug rather than as a confusing NPE inside `refreshAddressIfChanged`. 2. The `LOG.warn` at the `IllegalArgumentException` catch and the one at `RPC.stopProxy` failure now pass the exception object (not `.getMessage()`), so SLF4J emits the full stack trace. 3. `testRefreshUpdatesDelegationTokenService` was indeed vacuous: the original assertion would pass even if the refresh code forgot to rebuild `dtService`. Added a `setCachedDtServiceForTest` hook, stale the field with a sentinel value before refresh, and assert post-refresh that `dtService` equals `SecurityUtil.buildTokenService(info.getAddress())`. A regression that skipped the `dtService` swap would now fail this test. Also retitled the PR to HDDS-15531 per @szetszwo's subtask request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
