kerneltime commented on PR #10473:
URL: https://github.com/apache/ozone/pull/10473#issuecomment-4688062775
Status update on the 4-PR split: all four are now retitled to their per-PR
subtask Jiras and addressed @szetszwo's and Copilot's review comments.
- #10485 — HDDS-15514. Pass Ratis peer addresses as hostnames
- Collapsed `createRaftPeer` into one method using `omNode.getNodeId()`,
updated `newOMRatisServer` to iterate `peerNodes.values()` (per @szetszwo).
- Reworded the Javadoc and SCM-side comments per Copilot's feedback: the
invariant is "pass the configured host string through verbatim; don't
pre-resolve into `InetSocketAddress`", and IP-literal configs are explicitly
noted as still honored.
- #10486 → renamed to **HDDS-15531. DNS refresh on connection failure for
Client to OM**
- `OMProxyInfo.setCachedAddressForTest` now requires non-null.
- The two `LOG.warn` calls in the refresh path now pass the exception
object (full stack trace) instead of just `.getMessage()`.
- `testRefreshUpdatesDelegationTokenService` was vacuous; added
`setCachedDtServiceForTest` hook, stale `dtService` with a sentinel, and assert
post-refresh equality against
`SecurityUtil.buildTokenService(info.getAddress())`.
- Reworded the "torn value" concurrency term in
`HadoopRpcOMFollowerReadFailoverProxyProvider.getConnectionId()` — reference
reads are atomic per JLS, so the hazard is stale visibility, not tearing.
- #10487 → renamed to **HDDS-15532. DNS refresh on connection failure for OM
to SCM**
- Rebased onto the updated #10486. Inherits the wording fixes above; no
SCM-specific code changes were requested.
- #10488 → renamed to **HDDS-15533. DNS refresh on heartbeat failure for DN
to SCM**
- Rebased onto the updated #10487. Will re-request the Copilot review pass
once the stack settles (the first pass errored).
All four PRs remain drafts (per @adoroszlai's CI-budget note) and chain-test
locally clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
